Load plugins from tsconfig.json#773
Merged
Perryvw merged 14 commits intoTypeScriptToLua:masterfrom Mar 15, 2020
Merged
Conversation
ark120202
force-pushed
the
tsconfig-plugins
branch
from
48a7aa9 to
95895bf
Compare
Perryvw
approved these changes
Mar 14, 2020
|
|
||
| const plugin: tstl.Plugin = { | ||
| visitors: { | ||
| [ts.SyntaxKind.StringLiteral]: (node, context) => { |
Member
There was a problem hiding this comment.
Could you add a comment just describing what these (also the other two) plugins do, something like // Visit string literals, if original transformer returns a string literal, change the string to "bar" instead? That way it is also easier to link to these as example for our users/documentation.
| @@ -0,0 +1 @@ | |||
| module.exports = true; | |||
Member
There was a problem hiding this comment.
Wondering if we should somehow separate these files from the test files, maybe with a data/ directory? What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.