Skip to content

Transpile console.error/info/warn to regular print like console.log#766

Merged
Perryvw merged 2 commits intomasterfrom
feature/transpile-error-to-print
Dec 8, 2019
Merged

Transpile console.error/info/warn to regular print like console.log#766
Perryvw merged 2 commits intomasterfrom
feature/transpile-error-to-print

Conversation

@Perryvw
Copy link
Copy Markdown
Member

@Perryvw Perryvw commented Dec 8, 2019

No description provided.

@Perryvw Perryvw requested a review from lolleko December 8, 2019 15:45
const parameters = transformArguments(context, expression.arguments, signature);

switch (methodName) {
case "error":
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also add the remaining console API functions like log, warn ...

https://console.spec.whatwg.org/#console-namespace

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, added .info and .warn too

@Perryvw Perryvw changed the title Transpile console.error to regular print like console.log Transpile console.error/info/warn to regular print like console.log Dec 8, 2019
@Perryvw Perryvw merged commit 3bd4333 into master Dec 8, 2019
@Perryvw Perryvw deleted the feature/transpile-error-to-print branch December 8, 2019 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants