Merged
Conversation
ark120202
reviewed
Sep 7, 2019
ark120202
reviewed
Sep 9, 2019
Contributor
ark120202
left a comment
ark120202
left a comment
There was a problem hiding this comment.
I think it would be nice to give some more thought to option name. Actually noSelfInFile doesn't really fit it's purpose as well, since, unlike noSelf, it doesn't affect contexts where self is implied (like methods).
Co-Authored-By: ark120202 <ark120202@gmail.com>
Perryvw
reviewed
Sep 10, 2019
ark120202
reviewed
Sep 24, 2019
ark120202
approved these changes
Sep 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #716
New option:
--noImplicitSelf(boolean) (falseby default)Implicitly enables
@noSelfInFilefor all root files and will add the@noSelfInFileannotation to the top of generated declaration files.