Skip to content

Upgrade TypeScript to v3.6#714

Merged
Perryvw merged 5 commits intoTypeScriptToLua:masterfrom
ark120202:typescript-3.6
Sep 10, 2019
Merged

Upgrade TypeScript to v3.6#714
Perryvw merged 5 commits intoTypeScriptToLua:masterfrom
ark120202:typescript-3.6

Conversation

@ark120202
Copy link
Copy Markdown
Contributor

@ark120202 ark120202 commented Sep 2, 2019

Closes #713.

@Perryvw
Copy link
Copy Markdown
Member

Perryvw commented Sep 3, 2019

Do we have a test that fails in TS 3.6 because of this change? If not we shoudl probably add one, a snapshot test with /** @noSelfInFile */ and some other JSDoc on the first statement would suffice.

@Perryvw Perryvw merged commit 5735093 into TypeScriptToLua:master Sep 10, 2019
@ark120202 ark120202 deleted the typescript-3.6 branch November 26, 2019 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeScript 3.6 breaks how JSDoc comments work

3 participants