Skip to content

Add GitHub Actions workflows#707

Merged
ark120202 merged 5 commits intoTypeScriptToLua:masterfrom
ark120202:github-actions
Oct 6, 2019
Merged

Add GitHub Actions workflows#707
ark120202 merged 5 commits intoTypeScriptToLua:masterfrom
ark120202:github-actions

Conversation

@ark120202
Copy link
Copy Markdown
Contributor

@ark120202 ark120202 commented Aug 26, 2019

Requires 2 secrets: CODECOV_TOKEN and NPM_AUTH_TOKEN.
Few notes:

  • Tagged commits are published even if tests fail because CI and CD are different workflows. It could be possible to merge them to a single workflow, but currently there is no way to run job conditionally (https://github.community/t5/GitHub-API-Development-and/jobs-lt-job-id-gt-if-not-working/m-p/28980).
  • GitHub currently provides only one style for readme badges, so I've changed others for consistency
  • Some jobs have CI: true env, because ci-info doesn't support actions yet
  • Codecov doesn't work on pull requests and has continue-on-error: true because:
    • It requires a token (even for public projects) and fails when token is not provided
    • Secrets aren't available for runs from forks
    • if: secrets.CODECOV_TOKEN != null doesn't work for some reason

@ark120202 ark120202 marked this pull request as ready for review October 6, 2019 18:48
@ark120202 ark120202 merged commit 3603296 into TypeScriptToLua:master Oct 6, 2019
@ark120202 ark120202 deleted the github-actions branch October 6, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant