Preserving order in Map and Set using doubly linked lists#706
Merged
Preserving order in Map and Set using doubly linked lists#706
Conversation
Perryvw
requested review from
ark120202 and
tomblind
and removed request for
tomblind
tomblind
reviewed
Aug 26, 2019
tomblind
approved these changes
Aug 26, 2019
ark120202
reviewed
Aug 26, 2019
ark120202
reviewed
Aug 26, 2019
| expect(util.transpileAndExecute(`let m = new Map([[1,2],[3,4]]); m.delete(3); return m.size;`)).toBe(1); | ||
| }); | ||
|
|
||
| const iterationMethods = ["entries", "keys", "values"]; |
Contributor
There was a problem hiding this comment.
Maybe wrap all these new tests to a describe("iteration order", () => {}) block and remove preserves insertion order part in names?
ark120202
approved these changes
Aug 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code complicates a bit with the extra list bookkeeping. This does preserve O(1) insert and deletes. Iteration is still O(n), although it does include some extra table lookups, so probably more like O(2n) compared to the O(n) it was before.