@noSelf changed to not affect merged namespaces#689
Merged
Conversation
Perryvw
reviewed
Jul 25, 2019
| { | ||
| value: "anonMethodClassMergedNoSelfNS.method", | ||
| definition: `class AnonMethodClassMergedNoSelfNS { method(s: string): string { return s; } } | ||
| /** @noSelf */ namespace AnonMethodClassMergedNoSelfNS { export function nsFunc(s: string) { return s; } } |
Member
There was a problem hiding this comment.
Do these actually fail without the transformer change?
Collaborator
Author
There was a problem hiding this comment.
Yes, because the class method will have it's self stripped due to the namespace using @noSelf
Member
There was a problem hiding this comment.
But the call to the function will adjust accordingly?
Collaborator
Author
There was a problem hiding this comment.
Yes, but the assignment test would fail since it would try to assign the method to a type with a self parameter. Also, those tests actually call the function and verify parameters are in correct order. That could probably be moved out to separate tests, but that seems out of scope for this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #686
Previously, if a namespace or class was decorated with
@noSelf, this affected all declarations merged with it. This changes that behavior so, for example, methods in a class merged with a@noSelfdecorated namespace will retain theirselfparameter.Example:
=>