Assignment binding patterns#677
Merged
Perryvw merged 14 commits intoTypeScriptToLua:masterfrom Jul 27, 2019
Merged
Conversation
Contributor
|
This PR doesn't appear to do anything with variables declarations and |
Contributor
Author
|
The destructuring assignment AST shares no kinds of nodes with binding patterns. I tried it initially but I kept it out of scope as I ended up overhauling all binding and destructuring behaviour which wasn't my intention. |
tomblind
reviewed
Jul 23, 2019
tomblind
reviewed
Jul 23, 2019
tomblind
reviewed
Jul 23, 2019
tomblind
approved these changes
Jul 23, 2019
Perryvw
reviewed
Jul 26, 2019
| } | ||
|
|
||
| public transformExpressionStatement(statement: ts.ExpressionStatement | ts.Expression): StatementVisitResult { | ||
| const expression = ts.isExpressionStatement(statement) ? statement.expression : statement; |
Perryvw
approved these changes
Jul 27, 2019
tomblind
approved these changes
Jul 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #574
Closes #599
Before destructures were only made with a Lua statement.
This still happens as an optimisation but if the left hand side contains initializers, special assignments or nested destructuring patterns it reverts to an alternate method similar to how binding patterns currently work but separated into more methods.