Fixed referencing named function expressions#671
Merged
Conversation
ark120202
reviewed
Jul 17, 2019
src/LuaTransformer.ts
Outdated
| const symbol = this.checker.getSymbolAtLocation(node.name); | ||
| if (symbol) { | ||
| const symbolId = this.symbolIds.get(symbol); | ||
| if (symbolId && scope.referencedSymbols.has(symbolId)) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (symbolId && scope.referencedSymbols.has(symbolId)) { | |
| if (symbolId !== undefined && scope.referencedSymbols.has(symbolId)) { |
It can't happen in practice, since genSymbolIdCounter always starts from 1, but I think it's better to keep things safe when checking numbers and strings.
We probably should enable strict-boolean-expressions after we'll migrate to eslint.
Collaborator
Author
There was a problem hiding this comment.
Good catch. I'm definitely in favor of enabling strict-boolean-expressions.
Perryvw
reviewed
Jul 18, 2019
Perryvw
approved these changes
Jul 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #669
=>