Fixed empty destructuring declarations/assignments in for...of loops#658
Merged
Fixed empty destructuring declarations/assignments in for...of loops#658
Conversation
ark120202
reviewed
Jul 9, 2019
test/unit/loops.spec.ts
Outdated
| expect(result).toBe("0a1b2c"); | ||
| }); | ||
|
|
||
| test("forof array empty destructuring declaration", () => { |
Contributor
There was a problem hiding this comment.
Declaration/assignment versions of each test take quite a lot of space, maybe it would be better to generate them if the only difference is const []/[]? Something like:
describe("for...of empty destructuring", () => {
const declareTests = (destructuringPrefix: string) => {
test("array", () => {
const code = `
const arr = [["a"], ["b"], ["c"]];
let i = 0;
for (${destructuringPrefix}[] of arr) {
++i;
}
return i;
`;
expect(util.transpileAndExecute(code)).toBe(3);
});
// ...
};
describe("declaration", () => declareTests("const "));
describe("assignment", () => declareTests(""));
});
Perryvw
approved these changes
Jul 10, 2019
Member
Perryvw
left a comment
Perryvw
left a comment
There was a problem hiding this comment.
Approved, but fix the build please :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #607