Skip to content

Trying to fix polymorphism calls#63

Merged
Perryvw merged 3 commits intomasterfrom
polymorphism-fixes
Mar 11, 2018
Merged

Trying to fix polymorphism calls#63
Perryvw merged 3 commits intomasterfrom
polymorphism-fixes

Conversation

@Perryvw
Copy link
Copy Markdown
Member

@Perryvw Perryvw commented Mar 10, 2018

Messing around with instance calls again, now using : for interface and class calls.

Please try this branch and let me know if/what breaks.

@Perryvw Perryvw requested a review from lolleko March 10, 2018 20:51
@lolleko
Copy link
Copy Markdown
Member

lolleko commented Mar 10, 2018

Switch statements are broken because they use self too (my bad lol), should be an easy fix if you change it from self to something else in this line https://github.com/Perryvw/TypescriptToLua/blob/master/src/Transpiler.ts#L394 and adjust the jump calls accrodingly.

@Perryvw Perryvw merged commit 17378ef into master Mar 11, 2018
@Perryvw Perryvw deleted the polymorphism-fixes branch March 17, 2018 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lolleko lolleko Awaiting requested review from lolleko

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Perryvw @lolleko