Add multiple argument support to array.push()#62
Merged
Perryvw merged 5 commits intoTypeScriptToLua:masterfrom Mar 11, 2018
Merged
Add multiple argument support to array.push()#62Perryvw merged 5 commits intoTypeScriptToLua:masterfrom
Perryvw merged 5 commits intoTypeScriptToLua:masterfrom
Conversation
Member
|
Might be better to do that in lualib instead of hacking it into the translation. |
Contributor
Author
|
Yeah that's much cleaner. |
Member
|
Might also be better to use And the tests should be updated to. |
Member
|
If |
Member
|
I think JIT probably already optimises that, but its defiantly faster on other Lua versions. |
lolleko
approved these changes
Mar 10, 2018
Perryvw
reviewed
Mar 11, 2018
test/integration/lua/lualib.spec.ts
Outdated
| @TestCase([1], [0, 1]) | ||
| @TestCase([1, 2, 3], [0, 1, 2, 3]) | ||
| @Test("array.push") | ||
| public arrayPush(inp: number[], expected: number[]) { |
Member
There was a problem hiding this comment.
Remove expected from the arguments and compare to [0].concat(inp)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this is accepted the wiki can be updated too.