Skip to content

Add test builder#609

Merged
Perryvw merged 74 commits intoTypeScriptToLua:masterfrom
ark120202:new-testing-utils
Jul 31, 2019
Merged

Add test builder#609
Perryvw merged 74 commits intoTypeScriptToLua:masterfrom
ark120202:new-testing-utils

Conversation

@ark120202
Copy link
Copy Markdown
Contributor

Resolves #602.

@ark120202 ark120202 changed the title New test utils Add test builder May 28, 2019
@ark120202 ark120202 force-pushed the new-testing-utils branch 4 times, most recently from 0ead1e1 to fe8b438 Compare May 30, 2019 08:37
@ark120202 ark120202 force-pushed the new-testing-utils branch from fe8b438 to e2888e1 Compare May 30, 2019 09:14
@ark120202 ark120202 marked this pull request as ready for review July 29, 2019 10:32
Copy link
Copy Markdown
Member

@Perryvw Perryvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good stuff

@Perryvw
Copy link
Copy Markdown
Member

Perryvw commented Jul 29, 2019

I'm seeing 11 skipped, 2 todo in the test log, those should ideally be resolved or reverted before merging. (oops, accidentally closed this)

@Perryvw Perryvw closed this Jul 29, 2019
@Perryvw Perryvw reopened this Jul 29, 2019
@Perryvw Perryvw merged commit 0ed6fe3 into TypeScriptToLua:master Jul 31, 2019
@ark120202 ark120202 deleted the new-testing-utils branch November 26, 2019 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify result comparison tests

2 participants