Merged
Conversation
ark120202
reviewed
May 26, 2019
Co-Authored-By: ark120202 <ark120202@gmail.com>
tomblind
reviewed
May 26, 2019
test/unit/lualib/array.spec.ts
Outdated
| `return JSONStringify([${inp.toString()}].slice(${start}, ${end}))`, | ||
| ); | ||
|
|
||
| expect(result).toBe(JSON.stringify(inp.slice(start, end))); |
Collaborator
There was a problem hiding this comment.
It might be good to test calling slice with no arguments (since that's a common way to do an array copy).
| { inp: [0, 1, 2, 3], start: 4, deleteCount: 1, newElements: [8, 9] }, | ||
| { inp: [0, 1, 2, 3], start: 4, deleteCount: 0, newElements: [8, 9] }, | ||
| { inp: [0, 1, 2, 3, 4, 5], start: 5, deleteCount: 9, newElements: [10, 11] }, | ||
| { inp: [0, 1, 2, 3, 4, 5], start: 3, deleteCount: 2, newElements: [3, 4, 5] }, |
Collaborator
There was a problem hiding this comment.
We should test negative start indicies and undefined deleteCount.
| { inp: [0, 1, 2, 3], start: 4 }, | ||
| { inp: [0, 1, 2, 3, 4, 5], start: 3 }, | ||
| { inp: [0, 1, 2, 3, 4, 5], start: 2, deleteCount: 2 }, | ||
| { inp: [0, 1, 2, 3, 4, 5, 6, 7, 8], start: 5, deleteCount: 9, newElements: [10, 11] }, |
Collaborator
There was a problem hiding this comment.
Like above, it would probably be good to test negative start indicies here.
# Conflicts: # test/unit/lualib/lualib.spec.ts
tomblind
approved these changes
May 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.