Remove new from luaKeywords by hazzard993 · Pull Request #583 · TypeScriptToLua/TypeScriptToLua

hazzard993 · 2019-05-16T09:39:00Z

new is not a Lua keyword

local new = 0
print(new)

Output: 0

Busted (a Lua testing framework) uses this keyword in spy.new(...).

It is possible to use new as a property name in TS.

const object = {
    new: () => {}
};
object.new();

At the moment TSTL thinks it is a keyword and disallows this from working.

tomblind · 2019-05-16T12:08:17Z

#581 will re-enable use of the keywords in that list. So, this probably isn't needed.

The reason new is listed is to prevent users from accidentally breaking classes:

class Foo {
    static new() {}
}
const bar = new Foo(); // uh oh

I think a special check for this case is the better way to go.

Remove new from luaKeywords

da974b3

hazzard993 closed this May 16, 2019

hazzard993 deleted the new-is-not-a-lua-keyword branch May 17, 2019 07:28

Provide feedback