Merged
Conversation
- replaced toStringWithSourceMap with custom method - support for sourceRoot
Perryvw
approved these changes
May 11, 2019
Perryvw
requested changes
May 11, 2019
| // TODO is the file: part really required? and should this be handled in the printer? | ||
| .toStringWithSourceMap({file: path.basename(sourceFile, path.extname(sourceFile)) + ".lua"}); | ||
| const sourceRoot = this.options.sourceRoot | ||
| || (this.options.outDir ? path.relative(this.options.outDir, this.options.rootDir || process.cwd()) : "."); |
Member
There was a problem hiding this comment.
Tsc makes the source filename either only the filename or maybe a relative path (Definitely no absolute paths), but this does produce absolute paths, which should probably be changed.
Perryvw
approved these changes
May 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's still plenty more that can be done (mostly handling mappings for extra generated code like IIFEs and generators). But, this covers a bunch of common cases.