Improve string.replace implementation#549
Merged
Perryvw merged 1 commit intoTypeScriptToLua:masterfrom May 2, 2019
Merged
Conversation
ark120202
added a commit
to ark120202/TypeScriptToLua
that referenced
this pull request
May 2, 2019
This reverts commit cb2c479.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change.
Makes string.replace behave closer to ES:
searchValueandreplaceValue(as a string)Limitations wiki page has to be updated with a recommendation to use
string.gsubif there is a need for extra functionality.Optimization ideas for future:
searchValueorreplaceValueis a string literal it may be escaped during transpilationsearchValueis a regexp literal has no magic and has onlygflag it may be compiled to gsub without a limit