false default binding pattern values#538
Merged
Perryvw merged 4 commits intoTypeScriptToLua:masterfrom Apr 28, 2019
Merged
Conversation
Perryvw
reviewed
Apr 26, 2019
test/unit/bindingpatterns.spec.ts
Outdated
| { bindingString: "{x: foo, y}", objectString: "{x: true, y: false}", returnVariable: "foo" }, | ||
| { bindingString: "{x}", objectString: "{x: true}", returnVariable: "x", expectedResult: true }, | ||
| { | ||
| bindingString: "[x, y]", |
Member
There was a problem hiding this comment.
I don't think it's a good idea to adjust all existing tests for this. It is probably tidier if you just add a new test.each([<...>])("Binding patterns handle false correctly (%p)" with your false test cases.
Perryvw
reviewed
Apr 27, 2019
| bindingString: "{x, y: [z = true]}", | ||
| objectString: "{x: false, y: [false]}", | ||
| returnVariable: "z", | ||
| }, |
Member
There was a problem hiding this comment.
Could you add a test with simply the pattern [x = false] too?
Contributor
Author
There was a problem hiding this comment.
Array binding pattern default parameters don't work in variable declaration statements. I'll add this with another commit, doesn't look like it resulted in much more code to review
Perryvw
approved these changes
Apr 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #529
Default destructuring parameters are handled the same way default parameters are, with a nil check