Merged
Conversation
Perryvw
reviewed
Apr 17, 2019
|
|
||
| const scope = this.peekScope(); | ||
| if (!this.options.noHoisting && !scope.importStatements) { | ||
| scope.importStatements = []; |
Member
There was a problem hiding this comment.
I'm a little confused why this is not a strict violation, since peeking a scope could be undefined?
Contributor
There was a problem hiding this comment.
That's because of microsoft/TypeScript#13778, but it's possible to change peekScope return type to Scope | undefined.
Member
There was a problem hiding this comment.
Aha, we probably should make that change. Doesn't have to be in this PR though.
Perryvw
approved these changes
Apr 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #525