Merged
Conversation
Perryvw
reviewed
Mar 29, 2019
|
|
||
| /** @type {import("prettier").Options} */ | ||
| module.exports = { | ||
| printWidth: 100, |
Member
There was a problem hiding this comment.
Why is this 100 actually? I think it's 120 in tslint
Contributor
Author
There was a problem hiding this comment.
In linters max length is used as a strict limit, but it's possible to make lines shorter. In prettier printWidth it more like average length, as prettier tries to as fit much as possible code into printWidth, so usually it's better to keep it less than it was with linter. See https://prettier.io/docs/en/options.html#print-width and https://prettier.io/docs/en/rationale.html#print-width for details.
Though I'm fine either way, the difference between 100 and 120 is quite small.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
endOfLinelocally, but left it enabled on CI. That way it doesn't cause initial warnings withcore.autocrlf=true(default on Windows), yet prevents committing files with inconsistent line endings to the repo.