Skip to content

Migrate tests to Jest#491

Merged
Perryvw merged 25 commits intoTypeScriptToLua:masterfrom
ark120202:jest
Mar 26, 2019
Merged

Migrate tests to Jest#491
Perryvw merged 25 commits intoTypeScriptToLua:masterfrom
ark120202:jest

Conversation

@ark120202
Copy link
Copy Markdown
Contributor

Notable changes:

  • Switched testing framework to Jest
  • Heavily improved performance by improving caching and excluding unnecessary types
  • Enabled tslint on tests
  • Enabled prettier on tests (since they were reformatted anyway)
  • Fixed options.spec.ts not testing anything

Copy link
Copy Markdown
Member

@Perryvw Perryvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you rename test to __tests__?

@ark120202
Copy link
Copy Markdown
Contributor Author

Why did you rename test to __tests__?

It's more common and consistent with other jest directories like __snapshots__ and __mocks__. Though probably I should do it in different commits to preserve history, but that would need a manual rebase and not using squash & merge. Maybe it would be better to leave it in test/**/*.spec.ts, I don't have a preference on it.

@ark120202 ark120202 force-pushed the jest branch 2 times, most recently from 180f821 to 940dcf3 Compare March 24, 2019 16:08
@Perryvw Perryvw merged commit a200793 into TypeScriptToLua:master Mar 26, 2019
@ark120202 ark120202 deleted the jest branch November 26, 2019 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants