validating arguments passed to lua lib functions#484
Merged
Conversation
Perryvw
reviewed
Mar 17, 2019
src/LuaTransformer.ts
Outdated
| } | ||
|
|
||
| public transformStringCallExpression(node: ts.CallExpression): tstl.Expression { | ||
| public transformStringCallExpression(node: ts.CallExpression, signature: ts.Signature): tstl.Expression { |
Member
There was a problem hiding this comment.
Thinking about the API we want to make available for people to override the transformers, I have my doubts if adding this signature parameter is a good idea. We have a couple options here: Can we just get the signature from the node inside this function? Is this a function that should not be in the public interface? Or do we just keep it like this.
My main point being it is not really clear what this signature is or where you should get it from? Is it not just part of the call expression?
Collaborator
Author
There was a problem hiding this comment.
That's a good point. I'm pretty sure we can grab it inside the function - I was only passing it in since we already had it.
Perryvw
approved these changes
Mar 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #481