Conversation
Perryvw
requested review from
lolleko and
tomblind
and removed request for
lolleko
ark120202
reviewed
Mar 10, 2019
tomblind
reviewed
Mar 10, 2019
src/LuaTransformer.ts
Outdated
| let className = statement.name ? this.transformIdentifier(statement.name) : nameOverride; | ||
| let className = statement.name | ||
| ? this.transformIdentifier(statement.name) | ||
| : tstl.createIdentifier("____"); |
Collaborator
There was a problem hiding this comment.
There's actually a tstl.createAnnonymousIdentifier() function which can be used for these identifiers now.
src/LuaTransformer.ts
Outdated
| public transformClassExpression(expression: ts.ClassExpression): ExpressionVisitResult { | ||
| const className = expression.name !== undefined | ||
| ? this.transformIdentifier(expression.name) | ||
| : tstl.createIdentifier("____"); |
ark120202
reviewed
Mar 10, 2019
src/LuaPrinter.ts
Outdated
| [tstl.SyntaxKind.BitwiseOrOperator]: "|", | ||
| [tstl.SyntaxKind.BitwiseExclusiveOrOperator]: "~", | ||
| [tstl.SyntaxKind.BitwiseRightShiftOperator]: ">>", | ||
| [tstl.SyntaxKind.BitwiseArithmeticRightShift]: ">>>", |
Contributor
There was a problem hiding this comment.
Might be good to remove BitwiseArithmeticRightShift from AST, since it's not really a valid token
Collaborator
There was a problem hiding this comment.
Seconded - it doesn't make sense to have AST kinds for things that don't exist in lua.
tomblind
requested changes
Mar 12, 2019
src/LuaPrinter.ts
Outdated
| [tstl.SyntaxKind.BitwiseOrOperator]: "|", | ||
| [tstl.SyntaxKind.BitwiseExclusiveOrOperator]: "~", | ||
| [tstl.SyntaxKind.BitwiseRightShiftOperator]: ">>", | ||
| [tstl.SyntaxKind.BitwiseArithmeticRightShift]: ">>>", |
Collaborator
There was a problem hiding this comment.
Seconded - it doesn't make sense to have AST kinds for things that don't exist in lua.
tomblind
reviewed
Mar 14, 2019
src/LuaTransformer.ts
Outdated
| case ts.SyntaxKind.GreaterThanGreaterThanGreaterThanToken: | ||
| return this.transformBinaryBitOperation(tsOriginal, left, right, operator); | ||
| case ts.SyntaxKind.PlusToken: | ||
| if (ts.isBinaryExpression(tsOriginal)) { |
Collaborator
There was a problem hiding this comment.
Is this necessary here? Won't transformBinaryOperator already do this?
tomblind
approved these changes
Mar 14, 2019
lolleko
approved these changes
Mar 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue where
const foo = class Bar {}would translate as:The function will now just return
Bar.Also swapped around the meaning of right shift operators. Fixes #471