Fix array.sort compare function not working#458
Merged
Perryvw merged 3 commits intoTypeScriptToLua:masterfrom Feb 26, 2019
Merged
Fix array.sort compare function not working#458Perryvw merged 3 commits intoTypeScriptToLua:masterfrom
Perryvw merged 3 commits intoTypeScriptToLua:masterfrom
Conversation
ark120202
force-pushed
the
fix-array-sort-compare-fn
branch
from
4ef4aa1 to
7ebd63d
Compare
Perryvw
approved these changes
Feb 26, 2019
test/unit/lualib/lualib.spec.ts
Outdated
| @TestCase('["4", "5", "3", "2", "1"]', ["1", "2", "3", "4", "5"], "Number(a) - Number(b)") | ||
| @TestCase('["4", "5", "3", "2", "1"]', ["5", "4", "3", "2", "1"], "Number(b) - Number(a)") | ||
| @Test("array.sort with compare function") | ||
| public arraySortWithCompareFunction(array: string, expected: any, compare: string): void |
Member
There was a problem hiding this comment.
I would prefer tests where you compare the lua result with (a, b) => array.sort(a - b) in typescript (even if that means splitting this up into multiple tests)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.