Conversation
Perryvw
approved these changes
Feb 24, 2019
Perryvw
reviewed
Feb 24, 2019
| case "reverse": | ||
| case "sub": | ||
| case "unpack": | ||
| case "upper": |
Member
There was a problem hiding this comment.
Should we allow upper to be redefined? TS already has toUpperCase() that should translate to this? Same for several others of these.
Collaborator
Author
There was a problem hiding this comment.
Personally, I'd like to be able to disable the es libs altogether and just use lua's in some circumstances.
hazzard993
pushed a commit
to hazzard993/TypescriptToLua
that referenced
this pull request
Feb 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, tstl doesn't allow lua's string methods to be declared and used:
This PR explicitly enables lua's builtin string methods.