@luaIterator changed to apply to type, not function#448
Merged
Conversation
…e, not the generator function.
Perryvw
approved these changes
Feb 24, 2019
hazzard993
pushed a commit
to hazzard993/TypescriptToLua
that referenced
this pull request
Feb 26, 2019
…e, not the generator function. (TypeScriptToLua#448)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #396
Currently, the
@luaIteratordirective is applied to a function that generates an iterator. This causes issues with tracking that a type is a lua iterator for use in for...of loops.This PR changes the
@luaIteratorso that it is applied to the type itself:This allows that iterator to be passed around freely without losing the directive. It will correctly transpile to a native for...in loop regardless of its source.
Note this is a breaking change! But the old way was error-prone and inconsistent with how other directives work, so I believe it's worth requiring declarations to be updated.