Skip to content

Handling modules/namespaces nested via dot in their declaration name #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Perryvw merged 1 commit into from
Feb 21, 2019
Merged

Handling modules/namespaces nested via dot in their declaration name #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/LuaTransformer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1322,9 +1322,12 @@ export class LuaTransformer {
this.currentNamespace = statement;

// Transform moduleblock to block and visit it
if (statement.body && ts.isModuleBlock(statement.body)) {
if (statement.body && (ts.isModuleBlock(statement.body) || ts.isModuleDeclaration(statement.body))) {
this.pushScope(ScopeType.Block, statement);
const statements = this.performHoisting(this.transformStatements(statement.body.statements));
let statements = ts.isModuleBlock(statement.body)
? this.transformStatements(statement.body.statements)
: this.transformModuleDeclaration(statement.body);
statements = this.performHoisting(statements);
this.popScope();
result.push(tstl.createDoStatement(statements));
}
Expand Down
9 changes: 9 additions & 0 deletions test/unit/modules.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,13 @@ export class LuaModuleTests {
// Assert
Expect(lua).toBe(``);
}

@Test("Nested module with dot in name")
public nestedModuleWithDotInName(): void {
const code =
`module a.b {
export const foo = "foo";
}`;
Expect(util.transpileAndExecute("return a.b.foo;", undefined, undefined, code)).toBe("foo");
}
}