Skip to content

Support special characters in module names #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Perryvw merged 3 commits into from
Feb 20, 2019
Merged

Support special characters in module names #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cbbb0e0
transform to underscore when using module with kebab case
thatcosmonaut Feb 20, 2019
81f15b6
support replacement of other special characters
thatcosmonaut Feb 20, 2019
9bfff18
newline endings
thatcosmonaut Feb 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/LuaTransformer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ export class LuaTransformer {
return undefined;
}

const tstlIdentifier = (name: string) => "__TSTL_" + name;
const tstlIdentifier = (name: string) => "__TSTL_" + name.replace(new RegExp("-|\\$| |#|'", "g"), "_");
const importUniqueName = tstl.createIdentifier(tstlIdentifier(path.basename((importPath))));
const requireStatement = tstl.createVariableDeclarationStatement(
tstl.createIdentifier(tstlIdentifier(path.basename((importPath)))),
Expand Down
10 changes: 10 additions & 0 deletions test/translation/lua/modulesImportNamedSpecialChars.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
local __TSTL_kebab_module = require("kebab-module");
local TestClass = __TSTL_kebab_module.TestClass;
local __TSTL_dollar_module = require("dollar$module");
local TestClass = __TSTL_dollar_module.TestClass;
local __TSTL_singlequote_module = require("singlequote'module");
local TestClass = __TSTL_singlequote_module.TestClass;
local __TSTL_hash_module = require("hash#module");
local TestClass = __TSTL_hash_module.TestClass;
local __TSTL_space_module = require("space module");
local TestClass = __TSTL_space_module.TestClass;
10 changes: 10 additions & 0 deletions test/translation/lua/modulesImportRenamedSpecialChars.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
local __TSTL_kebab_module = require("kebab-module");
local RenamedClass = __TSTL_kebab_module.TestClass;
local __TSTL_dollar_module = require("dollar$module");
local RenamedClass = __TSTL_dollar_module.TestClass;
local __TSTL_singlequote_module = require("singlequote'module");
local RenamedClass = __TSTL_singlequote_module.TestClass;
local __TSTL_hash_module = require("hash#module");
local RenamedClass = __TSTL_hash_module.TestClass;
local __TSTL_space_module = require("space module");
local RenamedClass = __TSTL_space_module.TestClass;
5 changes: 5 additions & 0 deletions test/translation/ts/modulesImportNamedSpecialChars.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import {TestClass} from "kebab-module"
import {TestClass} from "dollar$module"
import {TestClass} from "singlequote'module"
import {TestClass} from "hash#module"
import {TestClass} from "space module"
5 changes: 5 additions & 0 deletions test/translation/ts/modulesImportRenamedSpecialChars.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import {TestClass as RenamedClass} from "kebab-module"
import {TestClass as RenamedClass} from "dollar$module"
import {TestClass as RenamedClass} from "singlequote'module"
import {TestClass as RenamedClass} from "hash#module"
import {TestClass as RenamedClass} from "space module"