Support special characters in module names#428
Merged
Perryvw merged 3 commits intoTypeScriptToLua:masterfrom Feb 20, 2019
Merged
Support special characters in module names#428Perryvw merged 3 commits intoTypeScriptToLua:masterfrom
Perryvw merged 3 commits intoTypeScriptToLua:masterfrom
Conversation
Contributor
|
Would it be ok to extend this PR to handle some other invalid characters in variable names? You can get away with single quotes, hashes, spaces, $ as well as hypens in file names and Lua and TypeScript are ok with it. Lua just gets upset with the resulting variable names. Extending your RegExp you can use this: const tstlIdentifier = (name: string) => "__TSTL_" + name
.replace(new RegExp("-|\\$| |#|'", "g"), "_");The translation tests could also be extended to cover these cases. import {TestClass} from "kebab-module"
import {TestClass} from "dollar$module"
import {TestClass} from "singlequote'module"
import {TestClass} from "hash#module"
import {TestClass} from "space module"import {TestClass as RenamedClass} from "kebab-module"
import {TestClass as RenamedClass} from "dollar$module"
import {TestClass as RenamedClass} from "singlequote'module"
import {TestClass as RenamedClass} from "hash#module"
import {TestClass as RenamedClass} from "space module" |
Contributor
Author
|
I guess there's no harm in being thorough. |
thatcosmonaut
changed the title
Contributor
Author
|
This now works with different special characters and not just hyphen. |
tomblind
approved these changes
Feb 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lua hates hyphens in variable names, so this fixes cases where an imported TypeScript module is named in kebab case.
Fixes #403