Merged
Conversation
Perryvw
reviewed
Feb 16, 2019
Member
Perryvw
left a comment
Perryvw
left a comment
There was a problem hiding this comment.
Looks good, just missing one test for the uniqueness of symbols. You'll also have to merge master to resolve the conflicts.
ark120202
force-pushed
the
custom-symbols
branch
from
cdd2f19 to
3a21564
Compare
tomblind
reviewed
Feb 16, 2019
Collaborator
tomblind
left a comment
tomblind
left a comment
There was a problem hiding this comment.
Great feature - makes sense since this is something that works easily in lua.
Perryvw
approved these changes
Feb 17, 2019
tomblind
approved these changes
Feb 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typeof Symbol()still returnsobject, since I don't see much need in this right now.Uses the same code as #402 to use exnext
Symbol.descriptiontype in tests.