Merged
Conversation
tomblind
requested changes
Feb 15, 2019
Collaborator
tomblind
left a comment
tomblind
left a comment
There was a problem hiding this comment.
Can you add a test to verify "weakness"? Something like this should work:
declare function collectgarbage(): void;
const wm = new WeakMap<{}, boolean>();
let a: {} | undefined = {};
wm.set(a, true);
a = undefined;
collectgarbage();
return wm.has(a);
Contributor
Author
|
@tomblind not unless it would be runned on real Lua VM, Fengari not implements gc. |
tomblind
approved these changes
Feb 15, 2019
Collaborator
tomblind
left a comment
tomblind
left a comment
There was a problem hiding this comment.
Oh, I see. It might be possible to do gc at the node.js level, but I'm not really sure how that could be set up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests don't check weak part, because Fengari not supports it.