named import prefix#362
Merged
Perryvw merged 3 commits intoTypeScriptToLua:ts-to-lua-astfrom Jan 26, 2019
Merged
Conversation
Perryvw
requested changes
Jan 26, 2019
src/LuaTransformer.ts
Outdated
| return tstl.createDoStatement(this.transformStatements(block.statements), undefined, block); | ||
| } | ||
|
|
||
| public tstlIdentifier(name: string): string { |
Member
There was a problem hiding this comment.
Having doubts if this should be a function. It would probably be better to just format the string inside the import declaration function, since that is the only place it's used anyway
Contributor
Author
There was a problem hiding this comment.
Ok, I moved the method into a local arrow function. I still like the function as it is more readable and maintainable imo.
Member
There was a problem hiding this comment.
Was thinking more along the lines of const importName = "__TSTL_" + path.basename(importPath) but this is okay too
Contributor
Author
There was a problem hiding this comment.
Yeah that does make more sense when used only here. On the other hand wouldn't it be nice to have some common prefix for all tstl auxiliary variables?
Perryvw
approved these changes
Jan 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent global shadowing by adding an tstl prefix to imported modules when using named imports.
Example below.