Conversation
* Initial Transformer Setup Added Transformer setup that allows us to incrementally port our transpile functions to transform functions. We have to prot all transpile functions that transpile Nodes that are not allowed in the 2nd AST. Once thats done we should restrucutre the whole project, because right now the transform process is just hacked before the transpilation. * Moved import path resolving from the transpiler to the transformer
* Addded NS Transformer * Added block transformation * Fixed manual block visit not being flattened * Flag var statements as static if no module exists * Revert "Merge branch 'master' into transformer-namespace" This reverts commit 773afae, reversing changes made to 743912a. * Removed statement static mod * Added a lot of transformers for expressions and statements * Added remaining implementations for transforms Transfrom & Transpile works now but there are still soem feature missing Many tests (especially translation) will fail aswell. * Fixed bug with default values for constructor parameters * Lualib omit when unused (#280) * lualib inline omit header when no features are used * Tests to enforce no lualib text when unused, unless using always * Fixed wrong version (git fail) * Updated alsatian * Improved empty block handling * Added empty lines between functions
* support in transformer for assignments * fixes for feedback and issues found in tests
…ToLua into ts-to-lua-ast
…ToLua into ts-to-lua-ast
* Fixing remaining tests - Fixed exporting enum members - Fixed exporting namespace members in a non-module - (Re)Fixed recursive functions - Updated transformation tests with aesthetic changes * corrected class export transform tests (which re-breaks them right now)
# Conflicts: # src/Transpiler.ts
# Conflicts: # src/Errors.ts # src/Transpiler.ts
…t code TODO fix tests
#355) * fixed additional issues with exported classes and a few transform tests where functions are now declared local * local/global/export logic fix - function and var are global unless inside a module, namespace or function - everything else is local - functions and function expressions properly separate declaration from assignment for recursion now - transform tests updated - also fixed noHeader not being respected when building lualib
Transformer exports
Perryvw
requested changes
Jan 26, 2019
* fix-lua-identifier * added test
* fix accessor assignment * add test * add brackets
* prefix import identifiers * refactor TSTL identifier function * update transformation tests
* Removed clang * Set codecov target back to 90 * Small formatting and typo fixes * Removed clang-format * Fixed PR issues * Fixed clean * Made a factory method for selfIdentifier, instead of reusing the same node
Perryvw
approved these changes
Jan 26, 2019
tomblind
reviewed
Jan 26, 2019
| TableIndexExpression, | ||
| // Operators | ||
| // Arithmetic | ||
| AdditionOperator, // Maybe use abreviations for those add, sub, mul ... |
Collaborator
There was a problem hiding this comment.
there's a lot of comments in this file that might make sense to remove now
tomblind
approved these changes
Jan 27, 2019
#364) * Removed todos * Changed tstl.create* parameter order to remove a lot of undefineds * Removed copy pasted casts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chaining our transpilation pipeline from:
TS Code ----> TS AST ----> Lua CodetoTS Code --tsc--> TS AST --transformer--> Lua AST --printer--> LuaCodeSee issues for more details.
Closes #278, Closes #286