Merged
Conversation
Perryvw
reviewed
Jan 20, 2019
Perryvw
approved these changes
Jan 20, 2019
* Fixing remaining tests - Fixed exporting enum members - Fixed exporting namespace members in a non-module - (Re)Fixed recursive functions - Updated transformation tests with aesthetic changes * corrected class export transform tests (which re-breaks them right now)
…t code TODO fix tests
#355) * fixed additional issues with exported classes and a few transform tests where functions are now declared local * local/global/export logic fix - function and var are global unless inside a module, namespace or function - everything else is local - functions and function expressions properly separate declaration from assignment for recursion now - transform tests updated - also fixed noHeader not being respected when building lualib
tomblind
approved these changes
Jan 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #286