properly handling bitwise operators #331
Merged
tomblind merged 4 commits intots-to-lua-astfrom Jan 11, 2019
Merged
Conversation
…e places it wasn't being passed
lolleko
reviewed
Jan 10, 2019
src/LuaAST.ts
Outdated
| BitwiseOrOperator, | ||
| BitwiseExclusiveOrOperator, | ||
| BitwiseRightShiftOperator, | ||
| BitwiseArithmaticRightShift, |
- Changed Arithmatic to Arithmetic - Throwing errors in printer in case something slips through from transformer - Throwing errors for unknown prefix/postifx unary ops - Move target-specific logic from subclasses to base transformer for bitops and unpack - Removed some unused helpers
Perryvw
approved these changes
Jan 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...and passing original nodes in some places it wasn't being passed