Skip to content

fixed compiler crash when unable to determine signature of function…#321

Merged
tomblind merged 2 commits intomasterfrom
function-expression-arg-fix
Jan 6, 2019
Merged

fixed compiler crash when unable to determine signature of function…#321
tomblind merged 2 commits intomasterfrom
function-expression-arg-fix

Conversation

@tomblind
Copy link
Copy Markdown
Collaborator

@tomblind tomblind commented Jan 6, 2019

…argument when passing a function expression

Cases like this:

declare const foo: any;
foo(() => "foo");

would cause the compiler to crash when trying to deduce if the passed function expression should have context or not. Now this will fail gracefully and the expression will be assumed to be a non-method.

@tomblind tomblind merged commit 92de529 into master Jan 6, 2019
@tomblind tomblind deleted the function-expression-arg-fix branch January 6, 2019 14:43
tomblind added a commit that referenced this pull request Jan 9, 2019
* fixed compiler crash when unable to determine signature of function… (#321)

* fixed compiler crash when unable to determine signature of function argument when passing a function expression

* added test

* Validation crash fix (#326)

* fix for crash when validating assignments of arrays/tuples

* added re-assignment code to tuple return test

* added new tuple assignment test and fixed others

* changed static methods and lambda-properties to take a context parameter by default (#322)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants