Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things that have to be done before this can be merged:
dist/they are already ignored but need to be removed aswellAfter merge:
Release system:
npm run release-minor(alternatives: release-patch or release-major)will trigger
npm versionwhich will build & test locally, if those steps succeed a tag is created and pushed to GitHub.Travis will then build & test and
npm publishthe repo.Things that should be done in the near Future:
Improve Readme and documentation (especially docs for custom decorators)
Change
tstl(Compiler.js) command line interface to be similar (or equal) totscAdd coveralls support for coverage tracking
Improve lualib integration: Right now lualib is a bit hidden in the dist/ folder and will be even lesss visible in npm packages. Therefore we should automatically require lualib into projects. For that we will need to include the typings (lib-typescript.d.ts) when typescript is parsing the source file (before compilation).
Then we need to add the lualib functions to the output (during compilation), 2 possible approaches for that are:
Keep track of functions/classes from lualib that are used and just copy them into the Lua source file where they are used e.g:
local TS_Splice = function() .....Copy typescript.lua to output root directory of the compiled project. and require('typescript') in each file where the lib is used. (It would be better if we changed typescript.lua to a module structure that way we can do local = require, and utilise the module cache)
Closes #17