Skip to content

Fixed default constructor on subclass #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Perryvw merged 1 commit into from
Dec 9, 2018
Merged

Fixed default constructor on subclass #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Transpiler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1789,7 +1789,7 @@ export abstract class LuaTranspiler {
if (constructor) {
// Add constructor plus initialization of instance fields
result += this.transpileConstructor(constructor, className);
} else if (!isExtension) {
} else if (!isExtension && !extendsType) {
// Generate a constructor if none was defined
result += this.transpileConstructor(ts.createConstructor([], [], [], ts.createBlock([], true)),
className);
Expand Down
53 changes: 53 additions & 0 deletions test/unit/class.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,59 @@ export class ClassTests {
Expect(result).toBe(4);
}

@Test("SubclassDefaultConstructor")
public subclassDefaultConstructor(): void {
const result = util.transpileAndExecute(
`class a {
field: number;
constructor(field: number) {
this.field = field;
}
}
class b extends a {}
return new b(10).field;`
);

Expect(result).toBe(10);
}

@Test("SubsubclassDefaultConstructor")
public subsubclassDefaultConstructor(): void {
const result = util.transpileAndExecute(
`class a {
field: number;
constructor(field: number) {
this.field = field;
}
}
class b extends a {}
class c extends b {}
return new c(10).field;`
);

Expect(result).toBe(10);
}

@Test("SubclassConstructor")
public subclassConstructor(): void {
const result = util.transpileAndExecute(
`class a {
field: number;
constructor(field: number) {
this.field = field;
}
}
class b extends a {
constructor(field: number) {
super(field + 1);
}
}
return new b(10).field;`
);

Expect(result).toBe(11);
}

@Test("classSuper")
public classSuper(): void {
// Transpile
Expand Down