Skip to content

Fix module namespace export enum bug #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Perryvw merged 4 commits into from
Oct 26, 2018
Merged

Fix module namespace export enum bug #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
41aa203
Merge pull request #2 from Perryvw/master
zengjie Jul 15, 2018
68168d9
Merge pull request #3 from Perryvw/master
zengjie Jul 16, 2018
e8680e0
Merge branch 'master' of https://github.com/Perryvw/TypescriptToLua
zengjie Oct 23, 2018
db29730
Fix error in module namespace enum exporting
zengjie Oct 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/Transpiler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,9 +444,7 @@ export abstract class LuaTranspiler {
const defName = this.definitionName(enumMember.name);
result += this.indent + `${defName}=${enumMember.value}\n`;
} else {
const defName = this.definitionName(
`${this.transpileIdentifier(node.name)}.${enumMember.name}`
);
const defName = `${this.transpileIdentifier(node.name)}.${enumMember.name}`;
result += this.indent + `${defName}=${enumMember.value}\n`;
}
});
Expand Down
10 changes: 10 additions & 0 deletions test/translation/lua/modulesNamespaceExportEnum.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
local exports = exports or {}
local test = exports.test or test or {}
do
local TestEnum={}
TestEnum.foo="foo"
TestEnum.bar="bar"
test.TestEnum = TestEnum
end
exports.test = test
return exports
6 changes: 6 additions & 0 deletions test/translation/ts/modulesNamespaceExportEnum.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
export namespace test {
export enum TestEnum {
foo = "foo",
bar = "bar",
}
}