Conditionals tests && Proposal new switch translation#25
Merged
lolleko merged 3 commits intoTypeScriptToLua:masterfrom Feb 16, 2018
lolleko:statement-tests
Merged
Conditionals tests && Proposal new switch translation#25lolleko merged 3 commits intoTypeScriptToLua:masterfrom lolleko:statement-tests
lolleko merged 3 commits intoTypeScriptToLua:masterfrom
lolleko:statement-tests
Conversation
Perryvw
reviewed
Feb 14, 2018
|
|
||
| // Assert | ||
| Expect(result).toBe(expected); | ||
| } |
Member
There was a problem hiding this comment.
Could you add a testcase where fallthrough has a visible effect? Like replacing the = with += here? Would like to test the return for inp 2 in this case. (should be 5)
src/Transpiler.ts
Outdated
|
|
||
| let result = this.indent + "-------Switch statement start-------\n"; | ||
|
|
||
| let jumpTableName = "____switch" + ++this.genVarCounter |
Member
There was a problem hiding this comment.
Don't inline assignments (incrementor in this case).
src/Transpiler.ts
Outdated
| && ts.isCaseClause(nextClause) | ||
| && nextClause.statements.length === 0 | ||
| ) { | ||
| nextClause = clauses[++i]; |
Member
There was a problem hiding this comment.
Don't inline assignments (incrementor).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.