Conversation
Perryvw
reviewed
Oct 14, 2018
src/TSHelper.ts
Outdated
| // export statement, we only check for export statements | ||
| return sourceFile.statements.some(statement => | ||
| (ts.getCombinedModifierFlags(statement) & ts.ModifierFlags.Export) !== 0 | ||
| (ts.getCombinedModifierFlags(statement as any as ts.Declaration) & ts.ModifierFlags.Export) !== 0 |
Member
There was a problem hiding this comment.
Is this because of TS3? Might be nicer to do sourceFile.statements.filter(ts.isDeclaration).some(ts.getCombinedModifierFlags.... if that avoids this hacky casting.
Member
Author
There was a problem hiding this comment.
Yes, even though I didn't update to TS3 I left that in there, so it's easier in the future.
Since we are only looking for exports I guess its fine to only check the declarations like you recommended.
Member
|
There's an empty src/LuaLibFeatures/ts file in changes I can't comment on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.