[WIP] Module rework#22
Merged
Perryvw merged 6 commits intoTypeScriptToLua:masterfrom Feb 11, 2018
lolleko:module-rework
Merged
Conversation
Exports table now wont be generated if file has not export statement
Perryvw
reviewed
Feb 11, 2018
src/TSHelper.ts
Outdated
| // export statement, we only check for export statements | ||
| let hasExport = false; | ||
| sourceFile.statements.forEach(statement => { | ||
| if (!!(ts.getCombinedModifierFlags(statement) & ts.ModifierFlags.Export) |
src/TSHelper.ts
Outdated
| // Vanilla ts flags files as external module if they have an import or | ||
| // export statement, we only check for export statements | ||
| let hasExport = false; | ||
| sourceFile.statements.forEach(statement => { |
Member
There was a problem hiding this comment.
This could probably be simplified using sourceFile.statements.some(...
src/Transpiler.ts
Outdated
|
|
||
| makeExport(name: string | ts.__String, node: ts.Node): string { | ||
| let result: string = ""; | ||
| if (node && node.modifiers && !!(ts.getCombinedModifierFlags(node) & ts.ModifierFlags.Export)) { |
src/Transpiler.ts
Outdated
|
|
||
| result += this.makeExport(methodName, node); | ||
|
|
||
|
|
| exports.TestSpace = exports.TestSpace or {} | ||
| do | ||
| end` | ||
| ) |
Member
There was a problem hiding this comment.
Add test with non-empty namespace.
| exports.TestSpace = exports.TestSpace or {} | ||
| do | ||
| end` | ||
| ) |
Member
There was a problem hiding this comment.
Add test with (non-empty) class.
Perryvw
reviewed
Feb 11, 2018
test/integration/lua/modules.spec.ts
Outdated
|
|
||
| const dedent = require('dedent') | ||
|
|
||
| export class LuaLoopTests { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.