Support shorthand property assignment in object literals#183
Merged
Perryvw merged 1 commit intoTypeScriptToLua:masterfrom Aug 26, 2018
gakada:ShorthandPropertyAssignment
Merged
Support shorthand property assignment in object literals#183Perryvw merged 1 commit intoTypeScriptToLua:masterfrom gakada:ShorthandPropertyAssignment
Perryvw merged 1 commit intoTypeScriptToLua:masterfrom
gakada:ShorthandPropertyAssignment
Conversation
Member
|
Can you provide some tests checking if the shorthand assignments were successful? |
Contributor
Author
|
Seems like travis is happy, though locally I have because of #186 |
Member
|
Please just test shorthand object assignment. Make sure #186 isn't an issue for your test. Also a unit test would be nicer than a translation test. |
Member
|
I would still like a test |
Contributor
Author
|
Oh there is |
Contributor
Author
|
Added in ObjectLiteralTests as well since it is not exactly an assignment. |
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.