Skip to content

Resolve bug inferring context type from generic functions in type parameters #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Perryvw merged 4 commits into from
Sep 24, 2024
Merged

Resolve bug inferring context type from generic functions in type parameters #1589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1655679
Resolve bug inferring context type from generic functions in type par…
Perryvw Sep 11, 2024
3d88104
remove previous fix
Perryvw Sep 21, 2024
1fff11f
Merge branch 'master' into function-assignment-2
Perryvw Sep 23, 2024
36077bc
Fix false positive due to incorrect inference of generic function con…
Perryvw Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/transformation/utils/function-context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,10 @@ function computeDeclarationContextType(context: TransformationContext, signature
return ContextType.NonVoid;
}

if (signatureDeclaration.parent && ts.isTypeParameterDeclaration(signatureDeclaration.parent)) {
return ContextType.NonVoid;
}

// When using --noImplicitSelf and the signature is defined in a file targeted by the program apply the @noSelf rule.
const program = context.program;
const options = program.getCompilerOptions() as CompilerOptions;
Expand Down
17 changes: 17 additions & 0 deletions test/unit/functions/validation/validFunctionAssignments.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,3 +248,20 @@ test("Does not fail on union type signatures (#896)", () => {
)
.expectToHaveNoDiagnostics();
});

// https://github.com/TypeScriptToLua/TypeScriptToLua/issues/1568
test("No false positives when using generic functions (#1568)", () => {
util.testModule`
/** @noSelf */
declare namespace Test {
export function testCallback<T extends (...args: any[]) => void>(
callback: T,
): void;
}

Test.testCallback(() => {});

const f = () => {};
Test.testCallback(f);
`.expectToHaveNoDiagnostics();
});