chore: update eslint to latest#1588
Merged
Perryvw merged 2 commits intoTypeScriptToLua:masterfrom Sep 25, 2024
Zamiell:eslint
Merged
chore: update eslint to latest#1588Perryvw merged 2 commits intoTypeScriptToLua:masterfrom Zamiell:eslint
Perryvw merged 2 commits intoTypeScriptToLua:masterfrom
Zamiell:eslint
Conversation
Perryvw
reviewed
Sep 24, 2024
test/transpile/module-resolution/project-with-tstl-library-has-exports-field/tsconfig.json
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1582
RE: no-default-export
I spent a few hours trying to get
eslint-plugin-importworking, but was not able to. Afterwards, I realized that we are only using one rule from that plugin called "no-default-export", which just bans "export default foo". I don't think we are getting much value from that rule, so it makes sense just to remove it, especially since there are a bunch of "eslint-disable" for it in the codebase.RE: ?? changes
Newer versions of the nullish-coalescing rules trigger on the existing codebase, so I went ahead and fixed the code to satisfy them.
RE: enhanced-resolve
I had to lock the version to prevent a build error. You might want to open an issue here: https://github.com/webpack/enhanced-resolve/issues
RE: strict
I had to add strict to the tsconfigs for tests, since several rules require strict to be on. (The new version of TSESLint uses the closest tsconfig.json to lint the file.)
RE: ci
had to update stuff in CI because linting was failing due to an old node version
In a future PR I think we should use the recommended rules from ESLint + TSESLint.