Add basic check for customName in property access transform#1534
Merged
Perryvw merged 1 commit intoTypeScriptToLua:masterfrom Feb 7, 2024
aabajyan:custom-name-in-access
Merged
Add basic check for customName in property access transform#1534Perryvw merged 1 commit intoTypeScriptToLua:masterfrom aabajyan:custom-name-in-access
Perryvw merged 1 commit intoTypeScriptToLua:masterfrom
aabajyan:custom-name-in-access
Conversation
Perryvw
reviewed
Feb 6, 2024
| const type = context.checker.getTypeAtLocation(node.expression); | ||
| const isOptionalLeft = isOptionalContinuation(node.expression); | ||
|
|
||
| // FIXME: Stuff like very.nested.call won't work, because |
Member
There was a problem hiding this comment.
I tested with
/** @noSelf */
interface Nested {
/** @customName pass */
fail(): void;
}
declare namespace TestNamespace {
const nested: Nested;
}
TestNamespace.nested.fail();And
/** @noSelf */
interface Nested {
/** @customName pass */
fail(): void;
}
declare const TestObject: {
nested: Nested;
};
TestObject.nested.fail();And they both seem to work fine with custom name. Can you give an example test case where it doesn't work?
Contributor
Author
There was a problem hiding this comment.
Sure
/** @noSelf */
declare namespace TestNamespace {
/** @customName very.nested.call */
function fail(): void;
}
TestNamespace.fail();Will output:
TestNamespace["very.nested.call"]()Instead of:
TestNamespace.very.nested.call()
Member
There was a problem hiding this comment.
/** @customName very.nested.call */ Is not really intended behavior for customName at the moment.
I would prefer if you remove this FIXME comment and just deliver this code as it does seem to resolve the original bug. I think allowing nested customName values might be a nice follow-up feature for a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While simple name changes work as expected names with nested methods will still behave like string literals.
I will try to find a solution for this as well, but since this is my first commit I want to make this as simple as possible.
partially fixes #1528