Optimize Promise and Await (fixes #1499), fix Promise.resolve bug#1530
Merged
Perryvw merged 2 commits intoTypeScriptToLua:masterfrom Feb 4, 2024
Merged
Optimize Promise and Await (fixes #1499), fix Promise.resolve bug#1530Perryvw merged 2 commits intoTypeScriptToLua:masterfrom
Perryvw merged 2 commits intoTypeScriptToLua:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1499.
I've tried to find a shaky balance between readable and optimized code. I've refactored almost all of the recursive calls into tail calls, and also prevented calling coroutine.resume from inside pcall's. Additionally, I got rid of some of the unnecessary allocations, and discovered & fixed a bug with Promise.resolve (tests added).
The new Promise + Async version can handle virtually any amount of chained waits. Due to the coroutine.resume/pcall optimization, C stack doesn't grow, and due to tail calls Lua stack doesn't grow as well. It stays constant and very small: http://tpcg.io/_ZQYND5