Skip to content

Conversation

@Perryvw
Copy link
Member

@Perryvw Perryvw commented Nov 19, 2023

Update on top of #1510

  • Got rid of isContextualCallExpression.
  • Changed the signature of getDeclarationContextType(context, ts.SignatureDeclaration) to getCallContextType(context, ts.CallLikeExpression)
  • If context checking fails based on signature, instead try to find if the node of the called function is in a file with noSelfInFile

Fixes #1387

@Z3rio
Copy link
Contributor

Z3rio commented Nov 19, 2023

Havent had a deep dive in all of the changes yet, but it does look fair enough on a first glance, gr8 work :)

@Perryvw Perryvw merged commit 5d63b1c into master Nov 20, 2023
@Perryvw Perryvw deleted the pr/Z3rio/1510 branch November 20, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@noSelfInFile configuration option is ignored for Function

2 participants