Do not cause unrelated exception when throwing Error object in environment without debug module#1488
Merged
Do not cause unrelated exception when throwing Error object in environment without debug module#1488
Conversation
…nment without debug module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was reported in the discord.
Some environments remove the debug module for various reasons such as security. In that case throwing an
Errorobject should just contain anundefinedstack trace.Currently we try to get the stacktrace anyway and it is throwing a nil indexing exception in the Error constructor, that has been corrected in this PR.