Conversation
Perryvw
reviewed
Jul 22, 2018
build_lualib.ts
Outdated
| @@ -0,0 +1,25 @@ | |||
| import concat = require("concat"); | |||
Member
There was a problem hiding this comment.
Do we really need a dependency for this?
src/CommandLineParser.ts
Outdated
| luaLibImport: { | ||
| choices: ["inline", "require", "none"], | ||
| default: "inline", | ||
| describe: "Specify Lua target version.", |
src/Compiler.ts
Outdated
| try { | ||
| const rootDir = options.rootDir; | ||
|
|
||
| // console.log(`Transpiling ${sourceFile.fileName}...`); |
Member
There was a problem hiding this comment.
Either uncomment or remove (I like it to see which file is causing errors).
Member
Author
There was a problem hiding this comment.
It should probably only print on error then.
src/Index.ts
Outdated
| @@ -0,0 +1,5 @@ | |||
| #!/usr/bin/env node | |||
|
|
|||
| import {compile} from "./Compiler"; | |||
Member
There was a problem hiding this comment.
Is this file linted? Would expect { compile }
src/Transpiler.ts
Outdated
| let result = ""; | ||
| this.exportStack.pop().forEach(exp => result += this.makeExport(exp.name, exp.node, exp.dummy)); | ||
| this.exportStack.pop().forEach( | ||
| exp => result += this.makeExport(exp.name, exp.node, exp.dummy)); |
src/Transpiler.ts
Outdated
| element => ((element as ts.BindingElement).name as ts.Identifier | ||
| ).escapedText).join(","); | ||
| element => | ||
| (this.transpileIdentifier((element as ts.BindingElement).name as ts.Identifier))).join(","); |
Member
There was a problem hiding this comment.
transpileArrayBindingElement seems to fit here.
src/lualib/ArraySplice.ts
Outdated
| } else { | ||
| list[to] = undefined; | ||
| } | ||
|
|
src/lualib/ArraySplice.ts
Outdated
| @@ -0,0 +1,93 @@ | |||
| // https://www.ecma-international.org/publications/files/ECMA-ST/Ecma-262.pdf | |||
| function __TS__ArraySplice<T>(list: T[], start: number, deleteCount: number, ...items: T[]): T[] { | |||
| // 1. 2. | |||
Member
There was a problem hiding this comment.
I would either write out the pseudo-code in the comments or just remove them. These numbers don't really add anything imo.
src/lualib/Set.ts
Outdated
| } | ||
| } | ||
|
|
||
| public add(value: TValue) { |
| @@ -204,20 +204,26 @@ export class LuaLibArrayTests { | |||
| @TestCase([], "test1") | |||
Member
There was a problem hiding this comment.
This file should probably also be moved to test/unit/lualib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open PR to reimplement runtime lualib features in typescript.
Fixes #80, Closes #134
TODO Compiler option for different import modes
--luaLibImportrequirerequire a bundled lualib in each file basically the same we currently haveinlineinline the used lualib functions add the bottom of the file. (Probably default option)noImportdon't import or inline any runtime lib featuresthis will replaces the existing
--dontRequireLuaLibTODO Reimplement all lualib features in TS